Those seem like a decent option, except for the fact that:
1) They have about 50% of the capacity of an alkaline 9V battery. They might be able to handle relatively high current draws better, though.
2) They still require the user to have an additional battery type on hand, keep track of and support.
3) Price: that's $14 for one battery. Even collector's edition eneloops aren't that expensive on a per-cell cost basis.
When I was a growing up* I had so many things that ran on 9V batteries. The smoke detectors in my home, my walkie talkies, multiple R/C transmitters for my cars, trucks and boats and at least two radios. Today (several decades later), do you know how many devices I have that run off of 9V batteries? Just two: My Fisher F2 and its accompanying aftermarket pinpointer - both of these are used in the metal detecting hobby. Practically everything else I own that runs off of AAA or AA batteries. If it uses C or D batteries, I have special adapters for those where I can use my AA eneloops. And if something is absolutely mission critical and requires very low-temp performance, I also have a few Energizer Lithium AA batteries.
In this day and age, why the heck would anyone make a device that uses such an antiquated, inefficient and borderline useless battery type, unless there was a very special reason for doing so? Do I really want to use a battery that has internal resistance that's multiple orders of magnitude higher? The only thing I can think of (using pinpointers as an example) is that when Garrett designed their carrots, they wanted to keep research, development and production costs down so they stuck with the 9V battery. But that's a lousy excuse given how the newest pinpointers are compatible with AA batteries or use built-in lithiums. I'm suspecting it was laziness or arrogance of a manufacturer and that both scares and disappoints me as a consumer.
EDIT: I'd also like to add that your unintentional use of a red herring adds further support that there's almost no need for anything designed within the last 15 years (and for use with metal detectors) to use a 9V battery. I know you are trying to help and I appreciate your suggestion. If it weren't for the price, I'd probably buy what you linked to for use in my F2.
*One could argue I'm still growing up